Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make install command failure #35

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix make install command failure #35

merged 1 commit into from
Apr 3, 2024

Conversation

Wirena
Copy link
Contributor

@Wirena Wirena commented Apr 2, 2024

Problem

  • Run CLI installation commands from readme
$ mkdir build
$ cd build/

$ cmake ..
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done (0.2s)
-- Generating done (0.0s)
-- Build files have been written to: /home/wirena/Code/Build/inifile-cpp/build


$ sudo make install
Install the project...
-- Install configuration: ""
CMake Error at cmake_install.cmake:51 (file):
  file INSTALL cannot find "/home/wirena/Code/Build/inifile-cpp/inicpp": No
  such file or directory.
make: *** [Makefile:110: install] Error 1
  • make install command tries to copy non-existing file and fails

Toolchains:

  • OS: Linux 6.1.80-1-MANJARO
  • CMake version 3.28.3
  • gcc version 13.2.1 20230801

Also tried it on raspbian:

  • OS: Linux 6.1.21-v8+
  • CMake version 3.18.4
  • gcc version 10.2.1 20210110

Not sure if using cmake(FILES ... is the right way, but this works on my system. Haven't tested it on Windows

Rookfighter
Rookfighter approved these changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@Rookfighter Rookfighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 👍 I think I missed this one after some refactoring. I might have to add an install test in the CI to prevent this in the future.

@Rookfighter Rookfighter merged commit 6986c5a into Rookfighter:master Apr 3, 2024
6 checks passed
@Wirena Wirena deleted the fix-make-install branch April 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rookfighter Rookfighter Rookfighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wirena @Rookfighter